Issue 1379163002: Some changes to service protocol before we land 1.13.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1379163002: Some changes to service protocol before we land 1.13. (Closed)

Created:
5 years, 2 months ago by turnidge

Modified:
5 years, 2 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org, nweiz, devoncarew, danrubel

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Some changes to service protocol before we land 1.13. - Split AddBreakpoint into two rpcs: AddBreakpoint and AddBreakpointWithScriptUri. - Remove Isolate.entry. Closes #24329 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/473413753dcfc57cdb7cccb276402ec5f3cf0eb9

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -55 lines)			Patch
M	CHANGELOG.md	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/observatory/lib/src/service/object.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/isolate.cc	View	1 2	1 chunk	+0 lines, -9 lines	0 comments	Download
M	runtime/vm/service.cc	View		4 chunks	+45 lines, -33 lines	0 comments	Download
M	runtime/vm/service/service.md	View	1	5 chunks	+40 lines, -12 lines	0 comments	Download

Total messages: 5 (1 generated)

turnidge

Devon and Natalie - heads up, breaking some more stuff before we land 1.13.

5 years, 2 months ago (2015-10-01 17:13:26 UTC) #2

turnidge

5 years, 2 months ago (2015-10-01 17:46:48 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
473413753dcfc57cdb7cccb276402ec5f3cf0eb9 (presubmit successful).