Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 137893024: Revert "Reapply "Implement new model for class members." and "Implement new model for interface mem… (Closed)

Created:
6 years, 11 months ago by floitsch
Modified:
6 years, 11 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, sra1
Visibility:
Public.

Description

Revert "Reapply "Implement new model for class members." and "Implement new model for interface members."" This reverts commit r31917. Committed: https://code.google.com/p/dart/source/detail?r=31929

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -1868 lines) Patch
M sdk/lib/_internal/compiler/implementation/compiler.dart View 1 chunk +0 lines, -57 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_types.dart View 11 chunks +28 lines, -155 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/elements.dart View 5 chunks +1 line, -93 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/modelx.dart View 3 chunks +0 lines, -16 lines 0 comments Download
D sdk/lib/_internal/compiler/implementation/elements/names.dart View 1 chunk +0 lines, -87 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart View 1 chunk +1 line, -2 lines 0 comments Download
D sdk/lib/_internal/compiler/implementation/resolution/class_members.dart View 1 chunk +0 lines, -303 lines 0 comments Download
D sdk/lib/_internal/compiler/implementation/resolution/member_impl.dart View 1 chunk +0 lines, -199 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 12 chunks +37 lines, -78 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/resolution.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/typechecker.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/use_unused_api.dart View 4 chunks +0 lines, -11 lines 0 comments Download
D tests/compiler/dart2js/in_user_code_test.dart View 1 chunk +0 lines, -97 lines 0 comments Download
M tests/compiler/dart2js/lookup_member_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
D tests/compiler/dart2js/members_test.dart View 1 chunk +0 lines, -681 lines 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 2 chunks +3 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/missing_file_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/package_root_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/type_test_helper.dart View 3 chunks +20 lines, -50 lines 0 comments Download
D tests/language/cyclic_metadata_test.dart View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
floitsch
Unfortunately this broke dart2dart... TBR.
6 years, 11 months ago (2014-01-17 19:15:47 UTC) #1
floitsch
Committed patchset #1 manually as r31929 (presubmit successful).
6 years, 11 months ago (2014-01-17 19:16:31 UTC) #2
Johnni Winther
6 years, 11 months ago (2014-01-18 12:20:28 UTC) #3
Message was sent while issue was closed. 
LGTM :(

Powered by Google App Engine
This is Rietveld 408576698