Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 13787003: Wrap stdout/stderr/stdin to only expose the relevant methods. (Closed)

Created:
7 years, 8 months ago by Anders Johnsen
Modified:
7 years, 6 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Wrap stdout/stderr/stdin to only expose the relevant methods. BUG=https://code.google.com/p/dart/issues/detail?id=9439,https://code.google.com/p/dart/issues/detail?id=9593 Committed: https://code.google.com/p/dart/source/detail?r=21063

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -5 lines) Patch
M runtime/bin/socket_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/stdio_patch.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/io/stdio.dart View 2 chunks +43 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Anders Johnsen
7 years, 8 months ago (2013-04-08 12:02:05 UTC) #1
Søren Gjesse
lgtm
7 years, 8 months ago (2013-04-08 12:10:32 UTC) #2
Anders Johnsen
Committed patchset #1 manually as r21063 (presubmit successful).
7 years, 8 months ago (2013-04-08 12:13:14 UTC) #3
ahe
DBC https://codereview.chromium.org/13787003/diff/1/sdk/lib/io/stdio.dart File sdk/lib/io/stdio.dart (right): https://codereview.chromium.org/13787003/diff/1/sdk/lib/io/stdio.dart#newcode44 sdk/lib/io/stdio.dart:44: Future<T> consume(Stream<List<int>> stream) => _ioSink.consume(stream); The use of ...
7 years, 8 months ago (2013-04-08 12:25:25 UTC) #4
Anders Johnsen
7 years, 6 months ago (2013-06-11 12:15:04 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/13787003/diff/1/sdk/lib/io/stdio.dart
File sdk/lib/io/stdio.dart (right):

https://codereview.chromium.org/13787003/diff/1/sdk/lib/io/stdio.dart#newcode44
sdk/lib/io/stdio.dart:44: Future<T> consume(Stream<List<int>> stream) =>
_ioSink.consume(stream);
On 2013/04/08 12:25:25, ahe wrote:
> The use of T without having T declared causes a warning from apidoc, and
breaks
> a dart2js test which attempts to ensure our API is free of warnings.

Yeah, bad testing from my side. Sorry

https://codereview.chromium.org/13647019

Powered by Google App Engine
This is Rietveld 408576698