Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 137863002: Issue 8742. Preserve leading line comments during java2dart translation. (Closed)

Created:
6 years, 11 months ago by scheglov
Modified:
6 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Issue 8742. Preserve leading line comments during java2dart translation. https://code.google.com/p/dart/issues/detail?id=8742 R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=31790

Patch Set 1 #

Total comments: 6

Patch Set 2 : Test for block-style comment translation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3290 lines, -99 lines) Patch
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/SyntaxTranslator.java View 5 chunks +24 lines, -2 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/util/ToFormattedSourceVisitor.java View 3 chunks +21 lines, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SyntaxTranslatorTest.java View 1 1 chunk +44 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/ast.dart View 25 chunks +63 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 18 chunks +36 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 55 chunks +215 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 72 chunks +279 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 3 chunks +5 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/html.dart View 23 chunks +35 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/index.dart View 34 chunks +90 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 77 chunks +291 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 347 chunks +1159 lines, -26 lines 0 comments Download
M pkg/analyzer/lib/src/generated/scanner.dart View 19 chunks +60 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk_io.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source_io.dart View 2 chunks +9 lines, -0 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/ast_test.dart View 2 chunks +12 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/element_test.dart View 88 chunks +408 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 20 chunks +139 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 107 chunks +284 lines, -66 lines 0 comments Download
M pkg/analyzer/test/generated/scanner_test.dart View 10 chunks +95 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 5 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 11 months ago (2014-01-14 06:08:39 UTC) #1
Brian Wilkerson
LGTM! Thanks! https://codereview.chromium.org/137863002/diff/1/editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SyntaxTranslatorTest.java File editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SyntaxTranslatorTest.java (right): https://codereview.chromium.org/137863002/diff/1/editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SyntaxTranslatorTest.java#newcode201 editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SyntaxTranslatorTest.java:201: // XXX Remove? https://codereview.chromium.org/137863002/diff/1/editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SyntaxTranslatorTest.java#newcode204 editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SyntaxTranslatorTest.java:204: "// filler ...
6 years, 11 months ago (2014-01-14 15:00:05 UTC) #2
scheglov
Committed patchset #2 manually as r31790 (presubmit successful).
6 years, 11 months ago (2014-01-14 16:29:12 UTC) #3
scheglov
6 years, 11 months ago (2014-01-14 16:29:33 UTC) #4
Message was sent while issue was closed. 
https://codereview.chromium.org/137863002/diff/1/editor/util/plugins/com.goog...
File
editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SyntaxTranslatorTest.java
(right):

https://codereview.chromium.org/137863002/diff/1/editor/util/plugins/com.goog...
editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SyntaxTranslatorTest.java:201:
// XXX
On 2014/01/14 15:00:06, Brian Wilkerson wrote:
> Remove?

Done.

https://codereview.chromium.org/137863002/diff/1/editor/util/plugins/com.goog...
editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SyntaxTranslatorTest.java:204:
"// filler filler filler filler filler filler filler filler filler filler",
On 2014/01/14 15:00:06, Brian Wilkerson wrote:
> It still misses non-doc comments at the beginning of the file. How many other
> kinds of comments is it missing?

Only comments before statements are kept.

https://codereview.chromium.org/137863002/diff/1/editor/util/plugins/com.goog...
editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SyntaxTranslatorTest.java:207:
"    // aaa",
On 2014/01/14 15:00:06, Brian Wilkerson wrote:
> Does it handle block comments? Perhaps convert one of these end-of-line
comments
> so that it gets tested.

Done.
We support both line and block styles of comments before statements.

Powered by Google App Engine
This is Rietveld 408576698