Issue 13784002: Only build apidoc in release mode.

Issue 13784002: Only build apidoc in release mode. (Closed)

Created:
7 years, 8 months ago by ahe

Modified:
7 years, 8 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Only build apidoc in release mode. Committed: https://code.google.com/p/dart/source/detail?r=21068

Patch Set 2 : Address comments #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -0 lines)			Patch
M	dart/tools/build.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	dart/tools/only_in_release_mode.py	View	1	1 chunk	+56 lines, -0 lines	0 comments	Download
M	dart/utils/apidoc/apidoc.gyp	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kustermann

lgtm https://codereview.chromium.org/13784002/diff/4001/dart/tools/only_in_release_mode.py File dart/tools/only_in_release_mode.py (right): https://codereview.chromium.org/13784002/diff/4001/dart/tools/only_in_release_mode.py#newcode18 dart/tools/only_in_release_mode.py:18: command line arguments as a command. Would be ...

7 years, 8 months ago (2013-04-08 12:30:54 UTC) #2

ahe

Thank you, Martin! https://codereview.chromium.org/13784002/diff/4001/dart/tools/only_in_release_mode.py File dart/tools/only_in_release_mode.py (right): https://codereview.chromium.org/13784002/diff/4001/dart/tools/only_in_release_mode.py#newcode18 dart/tools/only_in_release_mode.py:18: command line arguments as a command. ...

7 years, 8 months ago (2013-04-08 12:42:46 UTC) #3

ahe

7 years, 8 months ago (2013-04-08 12:43:36 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r21068 (presubmit successful).

Expand Messages | Collapse Messages