Issue 137793004: Fix scheduled stream usage of asBroadcastStream

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137793004: Fix scheduled stream usage of asBroadcastStream (Closed)

Created:
6 years, 11 months ago by ricow1

Modified:
6 years, 11 months ago

Reviewers:
nweiz, floitsch, Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix scheduled stream usage of asBroadcastStream This was causing tiemouts on the bots BUG: 16023 R=ajohnsen@google.com, floitsch@google.com, nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=31820

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -5 lines)			Patch
	M	pkg/pkg.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	pkg/scheduled_test/lib/scheduled_stream.dart	View		5 chunks	+14 lines, -4 lines	0 comments	Download

Total messages: 5 (0 generated)

Anders Johnsen

lgtm, but kinda biased, as I helped with this CL. :)

6 years, 11 months ago (2014-01-14 10:01:56 UTC) #2

nweiz

lgtm I'm also curious why this was causing timeouts, as well as why it was ...

6 years, 11 months ago (2014-01-14 19:35:54 UTC) #4

ricow1

6 years, 11 months ago (2014-01-15 07:52:28 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r31820 (presubmit successful).