Issue 137783019: Revert "Make VM TypedList not implement ByteBuffer."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137783019: Revert "Make VM TypedList not implement ByteBuffer." (Closed)

Created:
6 years, 11 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 11 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Revert "Make VM TypedList not implement ByteBuffer." Html transferable test fails to send buffer as buffer. Committed: https://code.google.com/p/dart/source/detail?r=31875

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+89 lines, -229 lines)			Patch
M	runtime/lib/typed_data.dart	View	10 chunks	+28 lines, -46 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/service_test.cc	View	8 chunks	+16 lines, -16 lines	0 comments	Download
M	runtime/vm/snapshot_test.cc	View	1 chunk	+33 lines, -33 lines	0 comments	Download
M	runtime/vm/symbols.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/typed_data/typed_data.dart	View	5 chunks	+2 lines, -19 lines	0 comments	Download
M	tests/co19/co19-co19.status	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	tests/lib/lib.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	tests/lib/typed_data/typed_list_buffer_test.dart	View	1 chunk	+0 lines, -83 lines	0 comments	Download
M	tests/standalone/io/file_typed_data_test.dart	View	6 chunks	+6 lines, -12 lines	0 comments	Download
M	tests/standalone/typed_data_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Lasse Reichstein Nielsen

Committed patchset #1 manually as r31875 (presubmit successful).

6 years, 11 months ago (2014-01-16 11:48:24 UTC) #2

Lasse Reichstein Nielsen

6 years, 11 months ago (2014-01-16 13:48:31 UTC) #3

Message was sent while issue was closed.

Reverted, buffer isn't sent correctly through window.postMessage.