Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Issue 137783007: remove resource.h from bin.gypi file (should fix windows build break) (Closed)

Created:
6 years, 11 months ago by siva
Modified:
6 years, 11 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Cutch
Visibility:
Public.

Description

remove resource.h from bin.gypi file (should fix windows build break) R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=31816

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M runtime/bin/bin.gypi View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
6 years, 11 months ago (2014-01-15 00:09:56 UTC) #1
Ivan Posva
LGTM -ip
6 years, 11 months ago (2014-01-15 00:11:33 UTC) #2
siva
6 years, 11 months ago (2014-01-15 00:17:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r31816 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698