Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1377663002: Add Timeline to dart:developer (Closed)

Created:
5 years, 2 months ago by Cutch
Modified:
5 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add Timeline to dart:developer - This CL only adds support for synchronous blocks of time. A follow up CL will add asynchronous blocks of time. - Reports true thread id to tracing system. This is an improvement over Mojo's tracing helper. - Dart events are included in individual isolate traces and global traces obtained via the embedders API. - Dart events are included in the write to disk path (--timeline_dir). R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/03b41129a2d21c3fb7c9a7ae7f29851a4aaec163

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 8

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+799 lines, -72 lines) Patch
M runtime/include/dart_tools_api.h View 1 2 2 chunks +8 lines, -5 lines 0 comments Download
M runtime/lib/developer_sources.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A runtime/lib/timeline.cc View 1 2 1 chunk +60 lines, -0 lines 0 comments Download
A runtime/lib/timeline.dart View 1 chunk +14 lines, -0 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 2 3 4 5 8 chunks +120 lines, -59 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 2 3 4 5 2 chunks +94 lines, -1 line 0 comments Download
M runtime/vm/timeline.h View 1 2 13 chunks +92 lines, -0 lines 0 comments Download
M runtime/vm/timeline.cc View 1 2 3 4 5 6 13 chunks +264 lines, -7 lines 0 comments Download
M runtime/vm/timeline_test.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/zone.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/zone.cc View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/developer_patch.dart View 1 2 3 4 1 chunk +15 lines, -0 lines 0 comments Download
M sdk/lib/developer/developer.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/developer/developer_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A sdk/lib/developer/timeline.dart View 1 2 3 4 5 1 chunk +103 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Cutch
5 years, 2 months ago (2015-09-29 19:51:14 UTC) #2
rmacnak
missing dart2js patches for new externals https://codereview.chromium.org/1377663002/diff/60001/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/1377663002/diff/60001/runtime/vm/dart_api_impl.cc#newcode5780 runtime/vm/dart_api_impl.cc:5780: // const intptr_t ...
5 years, 2 months ago (2015-09-29 22:36:41 UTC) #3
Cutch
PTAL https://codereview.chromium.org/1377663002/diff/60001/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/1377663002/diff/60001/runtime/vm/dart_api_impl.cc#newcode5780 runtime/vm/dart_api_impl.cc:5780: // const intptr_t kDataSize = 64 * KB; ...
5 years, 2 months ago (2015-09-30 14:42:29 UTC) #4
rmacnak
lgtm
5 years, 2 months ago (2015-09-30 16:40:57 UTC) #5
Cutch
5 years, 2 months ago (2015-10-01 16:30:53 UTC) #6
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) manually as
03b41129a2d21c3fb7c9a7ae7f29851a4aaec163 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698