Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1377543003: Clean up serialization of RawFunction, RawCode (Closed)

Created:
5 years, 2 months ago by siva
Modified:
5 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : more-cleanup #

Patch Set 3 : as-reference #

Total comments: 2

Patch Set 4 : code-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -29 lines) Patch
M runtime/vm/raw_object.h View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 2 3 2 chunks +27 lines, -18 lines 0 comments Download
M runtime/vm/snapshot.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
siva
5 years, 2 months ago (2015-09-28 21:10:31 UTC) #2
siva
PTAL.
5 years, 2 months ago (2015-09-28 23:02:22 UTC) #3
siva
PTAL
5 years, 2 months ago (2015-09-29 18:27:04 UTC) #4
rmacnak
lgtm https://codereview.chromium.org/1377543003/diff/40001/runtime/vm/raw_object_snapshot.cc File runtime/vm/raw_object_snapshot.cc (right): https://codereview.chromium.org/1377543003/diff/40001/runtime/vm/raw_object_snapshot.cc#newcode662 runtime/vm/raw_object_snapshot.cc:662: // Read the code object. Read the code ...
5 years, 2 months ago (2015-09-29 18:30:03 UTC) #5
siva
Committed patchset #4 (id:60001) manually as aac5baa90ef6451dc652ca19e7a5ecd6632cc1e0 (presubmit successful).
5 years, 2 months ago (2015-09-29 20:11:58 UTC) #6
siva
5 years, 2 months ago (2015-09-29 20:24:25 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1377543003/diff/40001/runtime/vm/raw_object_s...
File runtime/vm/raw_object_snapshot.cc (right):

https://codereview.chromium.org/1377543003/diff/40001/runtime/vm/raw_object_s...
runtime/vm/raw_object_snapshot.cc:662: // Read the code object.
On 2015/09/29 18:30:03, rmacnak wrote:
> Read the code object and fixup entry_point_.

Done.

Powered by Google App Engine
This is Rietveld 408576698