Moving ListBase, FixedLengthListMixin and UmodifiableListMixin to collection.

Moving ListBase, FixedLengthListMixin and UmodifiableListMixin to collection.

Users can now create lists easily by extending these classes, just
as they can create iterables by extending Iterable.

Reduce the dependency of IterableMixinWorkaround outside of core/collection
implementations. I plan to move IterableMixinWorkaround to _collection-dev
before M4.

Committed: https://code.google.com/p/dart/source/detail?r=21147

[floitsch, 2013-04-08 09:41:30]

FYI.
(still need to think/discuss about exposed classes before giving approval).

https://codereview.chromium.org/13774006/diff/1/sdk/lib/collection/list.dart
File sdk/lib/collection/list.dart (right):

https://codereview.chromium.org/13774006/diff/1/sdk/lib/collection/list.dart#...
sdk/lib/collection/list.dart:21: typedef FixedLengthListBase<E> = ListBase<E>
with FixedLengthListMixin<E>;
I'm not sure Lars will like this.
Why not just have one ListBase. Users can then throw on length= (for
FixedLength) and operator[]= (for unmodifiable).

[Lasse Reichstein Nielsen, 2013-04-08 10:17:22]

https://codereview.chromium.org/13774006/diff/1/sdk/lib/collection/list.dart
File sdk/lib/collection/list.dart (right):

https://codereview.chromium.org/13774006/diff/1/sdk/lib/collection/list.dart#...
sdk/lib/collection/list.dart:21: typedef FixedLengthListBase<E> = ListBase<E>
with FixedLengthListMixin<E>;
it's doable, but this is better optimizable and gives better error messages.
The methods on ListBase can be written without assuming that length= might, or
might not, throw, and so they can do other operations before writing to length.
The alternative is that some of them start with "this.length = this.length;" to
ensure early error.

[Lasse Reichstein Nielsen, 2013-04-08 10:22:14]

https://codereview.chromium.org/13774006/diff/1/sdk/lib/collection/list.dart
File sdk/lib/collection/list.dart (right):

https://codereview.chromium.org/13774006/diff/1/sdk/lib/collection/list.dart#...
sdk/lib/collection/list.dart:21: typedef FixedLengthListBase<E> = ListBase<E>
with FixedLengthListMixin<E>;
I can remove FixedLengthListBase and UnmodifiableListBase now, they are not
use/only used inside collection.

[Lasse Reichstein Nielsen, 2013-04-09 11:31:25]

PTAL

[floitsch, 2013-04-09 11:56:06]

LGTM.

https://codereview.chromium.org/13774006/diff/14001/sdk/lib/collection/collec...
File sdk/lib/collection/collections.dart (right):

https://codereview.chromium.org/13774006/diff/14001/sdk/lib/collection/collec...
sdk/lib/collection/collections.dart:346: return new _ReversedListIterable(list);
Move it back.

https://codereview.chromium.org/13774006/diff/14001/sdk/lib/collection/list.dart
File sdk/lib/collection/list.dart (right):

https://codereview.chromium.org/13774006/diff/14001/sdk/lib/collection/list.d...
sdk/lib/collection/list.dart:458: class _ReversedListIterable<E> extends
ListIterable<E> {
Move back.

[Lasse Reichstein Nielsen, 2013-04-09 12:11:25]

Committed patchset #5 manually as r21147 (presubmit successful).