Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 13771013: Add library id to code location object (Closed)

Created:
7 years, 8 months ago by hausner
Modified:
7 years, 8 months ago
Reviewers:
Tom Ball
CC:
reviews_dartlang.org, devoncarew
Visibility:
Public.

Description

Add library id to code location object Add libraryId field to the JSON Location object in the debugger wire protocol.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M runtime/bin/dbg_message.cc View 2 chunks +11 lines, -2 lines 0 comments Download
M runtime/include/dart_debugger_api.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/debugger_api_impl.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
7 years, 8 months ago (2013-04-08 17:41:32 UTC) #1
Tom Ball
lgtm
7 years, 8 months ago (2013-04-08 17:47:22 UTC) #2
hausner
7 years, 8 months ago (2013-04-08 18:53:38 UTC) #3
Message was sent while issue was closed.
On 2013/04/08 17:47:22, Tom Ball wrote:
> lgtm

This was committed at revision 21098.

Powered by Google App Engine
This is Rietveld 408576698