Issue 137703010: Add server and request handlers

Issue 137703010: Add server and request handlers (Closed)

Created:
6 years, 11 months ago by Brian Wilkerson

Modified:
6 years, 11 months ago

Reviewers:
devoncarew, danrubel

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add server and request handlers Committed: https://code.google.com/p/dart/source/detail?r=31982

Patch Set 1 #

Total comments: 6

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+769 lines, -0 lines)			Patch
A	pkg/analysis_server/lib/src/analysis_server.dart	View	1 chunk	+178 lines, -0 lines	0 comments	Download
A	pkg/analysis_server/lib/src/domain_context.dart	View	1 chunk	+204 lines, -0 lines	2 comments	Download
A	pkg/analysis_server/lib/src/domain_server.dart	View	1 chunk	+157 lines, -0 lines	2 comments	Download
A	pkg/analysis_server/test/domain_context_test.dart	View	1 chunk	+99 lines, -0 lines	2 comments	Download
A	pkg/analysis_server/test/domain_server_test.dart	View	1 chunk	+116 lines, -0 lines	0 comments	Download
A	pkg/analysis_server/test/test_all.dart	View	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

danrubel

https://codereview.chromium.org/137703010/diff/1/pkg/analysis_server/lib/src/domain_context.dart File pkg/analysis_server/lib/src/domain_context.dart (right): https://codereview.chromium.org/137703010/diff/1/pkg/analysis_server/lib/src/domain_context.dart#newcode15 pkg/analysis_server/lib/src/domain_context.dart:15: * that handles requests in the server domain. server ...

6 years, 11 months ago (2014-01-22 01:04:07 UTC) #2

Brian Wilkerson

Committed patchset #1 manually as r31982 (presubmit successful).

6 years, 11 months ago (2014-01-23 18:50:34 UTC) #3

Brian Wilkerson

6 years, 11 months ago (2014-01-24 21:49:27 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/137703010/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/domain_context.dart (right):

https://codereview.chromium.org/137703010/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/domain_context.dart:15: * that handles requests in
the server domain.
Done

https://codereview.chromium.org/137703010/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/domain_server.dart (right):

https://codereview.chromium.org/137703010/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/domain_server.dart:87: version(request);
> Do these need to return the response that is returned by the method call?

Yes, done.

https://codereview.chromium.org/137703010/diff/1/pkg/analysis_server/test/dom...
File pkg/analysis_server/test/domain_context_test.dart (right):

https://codereview.chromium.org/137703010/diff/1/pkg/analysis_server/test/dom...
pkg/analysis_server/test/domain_context_test.dart:36: Response response =
handler.applyChanges(request);
> Should these be tested via the handleRequest method rather than the sub
methods?

Probably. It would have caught one of the problems you saw. Done.

Expand Messages | Collapse Messages