Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1376433003: Fix the typing of FileSpan.{start,end}. (Closed)

Created:
5 years, 2 months ago by nweiz
Modified:
5 years, 2 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/source_span@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M lib/src/file.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 2 months ago (2015-09-30 20:27:15 UTC) #1
kevmoo
lgtm
5 years, 2 months ago (2015-09-30 20:34:33 UTC) #2
nweiz
5 years, 2 months ago (2015-09-30 20:37:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a9f70a893347a5cff65878d5ad719c0c54bcdf61 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698