Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 137623008: Add testing script to test Dartium on Android devices. (Closed)

Created:
6 years, 11 months ago by Bill Hesse
Modified:
6 years, 10 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add testing script to test Dartium on Android devices. BUG= R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=32103

Patch Set 1 #

Patch Set 2 : Flesh out testing script. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
A tools/bots/dartium_android.py View 1 1 chunk +36 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Bill Hesse
6 years, 11 months ago (2014-01-25 01:12:08 UTC) #1
ricow1
lgtm https://codereview.chromium.org/137623008/diff/30001/tools/bots/dartium_android.py File tools/bots/dartium_android.py (right): https://codereview.chromium.org/137623008/diff/30001/tools/bots/dartium_android.py#newcode2 tools/bots/dartium_android.py:2: # Copyright (c) 2013, the Dart project authors. ...
6 years, 11 months ago (2014-01-26 14:28:33 UTC) #2
Bill Hesse
Committed patchset #2 manually as r32103 (presubmit successful).
6 years, 10 months ago (2014-01-29 06:14:41 UTC) #3
Bill Hesse
6 years, 10 months ago (2014-01-29 06:25:25 UTC) #4
Message was sent while issue was closed.
On 2014/01/26 14:28:33, ricow1 wrote:
> lgtm
> 
>
https://codereview.chromium.org/137623008/diff/30001/tools/bots/dartium_andro...
> File tools/bots/dartium_android.py (right):
> 
>
https://codereview.chromium.org/137623008/diff/30001/tools/bots/dartium_andro...
> tools/bots/dartium_android.py:2: # Copyright (c) 2013, the Dart project
authors.
>  Please see the AUTHORS file
> 2014

Done.

Powered by Google App Engine
This is Rietveld 408576698