Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1376113002: dart2js: Remove ConcreteTypeInference (Closed)

Created:
5 years, 2 months ago by sra1
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4618 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/commandline_options.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 1 chunk +0 lines, -3 lines 0 comments Download
D pkg/compiler/lib/src/inferrer/concrete_types_inferrer.dart View 1 chunk +0 lines, -2405 lines 0 comments Download
M pkg/compiler/lib/src/types/types.dart View 7 chunks +4 lines, -36 lines 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 3 chunks +0 lines, -6 lines 0 comments Download
D tests/compiler/dart2js/cpa_inference_test.dart View 1 chunk +0 lines, -2160 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
sra1
Hi Paul, Thanks for helping us out in the early days of type inference.
5 years, 2 months ago (2015-09-30 03:50:35 UTC) #2
Siggi Cherem (dart-lang)
lgtm Just to be sure, this file: https://github.com/dart-lang/sdk/blob/master/tests/compiler/dart2js/concrete_type_inference_test.dart is about inferring concrete types, not about ...
5 years, 2 months ago (2015-09-30 17:07:42 UTC) #3
sra1
5 years, 2 months ago (2015-09-30 22:22:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
98531917c69d35b40f5aefda82cf8b8736d16bdc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698