Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 1376043002: add JsonCode example (Closed)

Created:
5 years, 2 months ago by sethladd
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M sdk/lib/convert/json.dart View 2 chunks +7 lines, -2 lines 1 comment Download

Messages

Total messages: 5 (1 generated)
sethladd
Came up from talking to a customer. Also, fixing formatting. Thanks for taking a look!
5 years, 2 months ago (2015-09-29 21:52:49 UTC) #2
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/1376043002/diff/1/sdk/lib/convert/json.dart File sdk/lib/convert/json.dart (right): https://codereview.chromium.org/1376043002/diff/1/sdk/lib/convert/json.dart#newcode56 sdk/lib/convert/json.dart:56: * var encoded = JSON.encode([1, 2, { "a": ...
5 years, 2 months ago (2015-09-30 06:20:31 UTC) #3
sethladd
Committed patchset #1 (id:1) manually as ab5af73d758f04b0b281abc8a2c9f05778bfe619 (presubmit successful).
5 years, 2 months ago (2015-09-30 18:02:07 UTC) #4
sethladd
5 years, 2 months ago (2015-09-30 18:03:18 UTC) #5
Message was sent while issue was closed.
Thanks for the review. The bug seems to be that number of intents is relative to
the *.

Powered by Google App Engine
This is Rietveld 408576698