Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 13760010: Rename the sdk/bin/dartanalyzer* scripts to dartanalyzer_developer*, and update (Closed)

Created:
7 years, 8 months ago by devoncarew
Modified:
7 years, 8 months ago
Reviewers:
ricow1, kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Rename the sdk/bin/dartanalyzer* scripts to dartanalyzer_developer*, and update the test framework to call the new scripts. This rename will allow us to add two new scripts to this directory, dartanalyzer and dartanalyzer.bat. These scripts will be the ones we include in the sdk. Committed: https://code.google.com/p/dart/source/detail?r=21213

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, -67 lines) Patch
D sdk/bin/dartanalyzer View 1 chunk +0 lines, -41 lines 0 comments Download
D sdk/bin/dartanalyzer.bat View 1 chunk +0 lines, -27 lines 0 comments Download
A + sdk/bin/dartanalyzer_developer View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sdk/bin/dartanalyzer_developer.bat View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
devoncarew
7 years, 8 months ago (2013-04-07 22:10:52 UTC) #1
devoncarew
PTAL - I need the sdk/bin/dartanalyzer name available for the sdk script
7 years, 8 months ago (2013-04-09 20:41:10 UTC) #2
ricow1
LGTM
7 years, 8 months ago (2013-04-10 05:49:28 UTC) #3
kustermann
lgtm
7 years, 8 months ago (2013-04-10 07:42:34 UTC) #4
devoncarew
7 years, 8 months ago (2013-04-10 16:01:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r21213 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698