Support bounded mixins in the VM (fix issue 14453).

Support bounded mixins in the VM (fix issue 14453).
Add tests.

R=gbracha@google.com, hausner@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31794

[gbracha, 2014-01-14 01:39:33]

Some comments on types. Otherwise lgtm on tests.

https://codereview.chromium.org/137543004/diff/1/tests/language/mixin_bound_t...
File tests/language/mixin_bound_test.dart (right):

https://codereview.chromium.org/137543004/diff/1/tests/language/mixin_bound_t...
tests/language/mixin_bound_test.dart:45: get val;
int get val to be consistently typed.

https://codereview.chromium.org/137543004/diff/1/tests/language/mixin_invalid...
File tests/language/mixin_invalid_bound2_test.dart (right):

https://codereview.chromium.org/137543004/diff/1/tests/language/mixin_invalid...
tests/language/mixin_invalid_bound2_test.dart:13: class B<U, V> extends S<U, V>
with M<int, int> { }
FWIW, B should cause a static warning as well because in S<U, V>, V is not known
to extend U. Likewise for D below, and similarly wrt M<U,V> in C and E below.

https://codereview.chromium.org/137543004/diff/1/tests/language/mixin_invalid...
File tests/language/mixin_invalid_bound_test.dart (right):

https://codereview.chromium.org/137543004/diff/1/tests/language/mixin_invalid...
tests/language/mixin_invalid_bound_test.dart:13: class B<T> extends S<T> with
M<int> { }
static type error in S<T> since T is not a subtype of num. Same in D. Analogous
situation with M<T> in C and E. Obviously M<bool> and S<bool> below as well.

https://codereview.chromium.org/137543004/diff/1/tests/language/mixin_invalid...
tests/language/mixin_invalid_bound_test.dart:25: new B<bool>();  /// 04: static
type warning, dynamic type error
To be clear, the warning stems from the definition of B, not this use.

https://codereview.chromium.org/137543004/diff/1/tests/language/mixin_invalid...
tests/language/mixin_invalid_bound_test.dart:27: new C<bool>();  /// 06: static
type warning, dynamic type error
as above. In fact, all the warnings are like this. If you care.

https://codereview.chromium.org/137543004/diff/1/tests/language/mixin_mixin_b...
File tests/language/mixin_mixin_bound2_test.dart (right):

https://codereview.chromium.org/137543004/diff/1/tests/language/mixin_mixin_b...
tests/language/mixin_mixin_bound2_test.dart:31: Expect.isTrue(c is
S<List<int>>);
This only works because of the arity error, right? c is really an S<Set<int>,
int>.

https://codereview.chromium.org/137543004/diff/1/tests/language/mixin_mixin_b...
tests/language/mixin_mixin_bound2_test.dart:33: Expect.isTrue(c is
M<Map<List<int>, Set<List<int>>>>);
Again, only true because of arity issues, correct?

https://codereview.chromium.org/137543004/diff/1/tests/language/mixin_mixin_b...
File tests/language/mixin_mixin_bound_test.dart (right):

https://codereview.chromium.org/137543004/diff/1/tests/language/mixin_mixin_b...
tests/language/mixin_mixin_bound_test.dart:26: Expect.isTrue(c is S<int>);
Only due to arity issue. Same for last case with M.

[hausner, 2014-01-14 18:09:14]

LGTM.

[regis, 2014-01-14 18:40:45]

Thanks!

https://codereview.chromium.org/137543004/diff/1/tests/language/mixin_bound_t...
File tests/language/mixin_bound_test.dart (right):

https://codereview.chromium.org/137543004/diff/1/tests/language/mixin_bound_t...
tests/language/mixin_bound_test.dart:45: get val;
On 2014/01/14 01:39:33, gbracha wrote:
> int get val to be consistently typed.

Done.

https://codereview.chromium.org/137543004/diff/1/tests/language/mixin_invalid...
File tests/language/mixin_invalid_bound2_test.dart (right):

https://codereview.chromium.org/137543004/diff/1/tests/language/mixin_invalid...
tests/language/mixin_invalid_bound2_test.dart:13: class B<U, V> extends S<U, V>
with M<int, int> { }
On 2014/01/14 01:39:33, gbracha wrote:
> FWIW, B should cause a static warning as well because in S<U, V>, V is not
known
> to extend U. Likewise for D below, and similarly wrt M<U,V> in C and E below.

Done.
I marked corresponding multitests with StaticWarning instead of adding bounds in
these classes. I want the bounds to be checked at the mixin or superclass level
to verify the implementation.
I do not know how to mark the 'none' multitest, though, so I added it to the
status file.

https://codereview.chromium.org/137543004/diff/1/tests/language/mixin_invalid...
File tests/language/mixin_invalid_bound_test.dart (right):

https://codereview.chromium.org/137543004/diff/1/tests/language/mixin_invalid...
tests/language/mixin_invalid_bound_test.dart:13: class B<T> extends S<T> with
M<int> { }
On 2014/01/14 01:39:33, gbracha wrote:
> static type error in S<T> since T is not a subtype of num. Same in D.
Analogous
> situation with M<T> in C and E. Obviously M<bool> and S<bool> below as well.

Done.

https://codereview.chromium.org/137543004/diff/1/tests/language/mixin_invalid...
tests/language/mixin_invalid_bound_test.dart:25: new B<bool>();  /// 04: static
type warning, dynamic type error
On 2014/01/14 01:39:33, gbracha wrote:
> To be clear, the warning stems from the definition of B, not this use.

Understood. Unfortunately, I do not see how to make the annotation clearer. I
added a comment.

https://codereview.chromium.org/137543004/diff/1/tests/language/mixin_invalid...
tests/language/mixin_invalid_bound_test.dart:27: new C<bool>();  /// 06: static
type warning, dynamic type error
On 2014/01/14 01:39:33, gbracha wrote:
> as above. In fact, all the warnings are like this. If you care.

Agreed.

https://codereview.chromium.org/137543004/diff/1/tests/language/mixin_mixin_b...
File tests/language/mixin_mixin_bound2_test.dart (right):

https://codereview.chromium.org/137543004/diff/1/tests/language/mixin_mixin_b...
tests/language/mixin_mixin_bound2_test.dart:33: Expect.isTrue(c is
M<Map<List<int>, Set<List<int>>>>);
On 2014/01/14 01:39:33, gbracha wrote:
> Again, only true because of arity issues, correct?

Another copy/paste error from a simpler test. Fixed.

https://codereview.chromium.org/137543004/diff/1/tests/language/mixin_mixin_b...
File tests/language/mixin_mixin_bound_test.dart (right):

https://codereview.chromium.org/137543004/diff/1/tests/language/mixin_mixin_b...
tests/language/mixin_mixin_bound_test.dart:26: Expect.isTrue(c is S<int>);
On 2014/01/14 01:39:33, gbracha wrote:
> Only due to arity issue. Same for last case with M.

Fixed.

https://codereview.chromium.org/137543004/diff/1/tests/language/mixin_mixin_b...
tests/language/mixin_mixin_bound_test.dart:28: Expect.isTrue(c is M<Map<int,
List<bool>>>);
Fixed here too.

[regis, 2014-01-14 18:41:35]

Committed patchset #2 manually as r31794 (presubmit successful).