Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 137533005: Whitespace testing fixes and bit-flip to turn on simple line breaking. (Closed)

Created:
6 years, 11 months ago by pquitslund
Modified:
6 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Whitespace testing fixes and bit-flip to turn on simple line breaking. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=31791

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -9 lines) Patch
M pkg/analyzer/lib/src/services/writer.dart View 1 4 chunks +8 lines, -8 lines 0 comments Download
M pkg/analyzer/test/services/data/stmt_tests.data View 1 chunk +6 lines, -1 line 0 comments Download
M pkg/analyzer/test/services/formatter_test.dart View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
pquitslund
Still not thrilled with how I'm testing for WS but this at least seems to ...
6 years, 11 months ago (2014-01-14 03:49:15 UTC) #1
Brian Wilkerson
LGTM
6 years, 11 months ago (2014-01-14 14:49:42 UTC) #2
pquitslund
6 years, 11 months ago (2014-01-14 16:46:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #5 manually as r31791 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698