Specification change for the 'libraryName' and 'partOfLibraryName' fields in Outline.

Specification change for the 'libraryName' and 'partOfLibraryName' fields in Outline.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/9d48af9ee390654848642daae0dff79118547a0f

[Paul Berry, 2015-10-01 16:00:44]

https://codereview.chromium.org/1375163003/diff/1/pkg/analysis_server/tool/sp...
File pkg/analysis_server/tool/spec/spec_input.html (right):

https://codereview.chromium.org/1375163003/diff/1/pkg/analysis_server/tool/sp...
pkg/analysis_server/tool/spec/spec_input.html:9: <h1
style="color:#999999">Version <version>1.9.0</version></h1>
Since this is a backward-compatible change to the API, we should rev the version
to 1.10.0.  Don't forget to also change the VERSION constant in
pkg/analysis_server/lib/src/analysis_server.dart.

https://codereview.chromium.org/1375163003/diff/1/pkg/analysis_server/tool/sp...
pkg/analysis_server/tool/spec/spec_input.html:1050: The name of the library
defined by the file.
We should clarify what happens if the file is the defining compilation unit of a
library, but the library is unnamed (i.e. there is neither a "library"
declaration nor a "part of" declaration).  Suggestion: in this case, libraryName
should be the empty string.

We should also clarify what happens if the file is a "part" file (i.e. it
contains a "part of" declaration).  Suggestion: in this case, libraryName should
be absent.  (And libraryName should be optional).

https://codereview.chromium.org/1375163003/diff/1/pkg/analysis_server/tool/sp...
pkg/analysis_server/tool/spec/spec_input.html:1062: The name of the library the
file in a part of.
We should clarify what happens if the file is not a "part" file (i.e. it lacks a
"part of" declaration).  Suggestion: in this case, partOfLibraryName should be
absent.  (And partOfLibraryName should be optional).

We should also clarify what happens if another file references this file as a
part, but this file lacks a "part of" declaration.  (This is an error condition
but it could arise during editing).  Suggestion: in this case, partOfLibraryName
should be absent.

[Brian Wilkerson, 2015-10-01 16:13:00]

https://codereview.chromium.org/1375163003/diff/1/pkg/analysis_server/tool/sp...
File pkg/analysis_server/tool/spec/spec_input.html (right):

https://codereview.chromium.org/1375163003/diff/1/pkg/analysis_server/tool/sp...
pkg/analysis_server/tool/spec/spec_input.html:1059: <field
name="partOfLibraryName">
Do we need to differentiate between a library and a part? I agree with Paul that
both "libraryName" and "partOfLibraryName" should be optional because there will
either be one or the other but never both. But I have to ask: would it work to
have one optional field whose value is the name in the library directive if one
exists, the name in the part-of directive if one exists, and otherwise it is
omitted? Doing so wouldn't allow a client to know whether they're looking at a
library or a part, but I don't know whether that's useful. If it is, it might be
less confusing to add a "kind" field.

[scheglov, 2015-10-01 16:28:47]

PTAL

[Paul Berry, 2015-10-01 16:37:43]

With the clarification below, lgtm.

https://codereview.chromium.org/1375163003/diff/20001/pkg/analysis_server/too...
File pkg/analysis_server/tool/spec/spec_input.html (right):

https://codereview.chromium.org/1375163003/diff/20001/pkg/analysis_server/too...
pkg/analysis_server/tool/spec/spec_input.html:1050: The kind of the file.
We should clarify what the kind of a file is if the file is referenced from
another library's "part" directive, but the file lacks a "part of" directive. 
Suggestion: such a file should be considered to be a LIBRARY.

[Brian Wilkerson, 2015-10-01 16:37:58]

LGTM

https://codereview.chromium.org/1375163003/diff/20001/pkg/analysis_server/too...
File pkg/analysis_server/tool/spec/spec_input.html (right):

https://codereview.chromium.org/1375163003/diff/20001/pkg/analysis_server/too...
pkg/analysis_server/tool/spec/spec_input.html:1059: nor 'part of' directives.
This should probably include a statement that the library directive takes
precedence over the part-of directive.

[Brian Wilkerson, 2015-10-01 16:41:04]

https://codereview.chromium.org/1375163003/diff/20001/pkg/analysis_server/too...
File pkg/analysis_server/tool/spec/spec_input.html (right):

https://codereview.chromium.org/1375163003/diff/20001/pkg/analysis_server/too...
pkg/analysis_server/tool/spec/spec_input.html:1050: The kind of the file.
I believe that analyzer currently concludes that the file is a part, but we
should send back the same kind that analyzer has selected for it. (I'm less
convinced that we need to specify it.)

[scheglov, 2015-10-01 16:53:28]

Committed patchset #3 (id:40001) manually as
9d48af9ee390654848642daae0dff79118547a0f (presubmit successful).