Fix for 'implemented' notification after an incremental change.

Fix for 'implemented' notification after an incremental change.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/1d28f99524f5861762007db419094cbd5d78f993

[Paul Berry, 2015-09-30 18:02:46]

lgtm with comment change we discussed in person.

Quick question, though: is the analyzer change needed in order to make the
analysis_server test change pass?  If so, then shouldn't we publish a new
version of analyzer and bump analysis_server's pub dependency?  (Otherwise users
of analysis_server who don't use a package root will see a test failure)

https://codereview.chromium.org/1374943005/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/incremental_resolver_test.dart (right):

https://codereview.chromium.org/1374943005/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/incremental_resolver_test.dart:4461: //
getElementAt() caches results, it should be notificed it when offset
"it should be notificed it when" -> "it should be notified when"

[Brian Wilkerson, 2015-09-30 18:05:16]

LGTM

https://codereview.chromium.org/1374943005/diff/20001/pkg/analysis_server/tes...
File pkg/analysis_server/test/analysis/notification_implemented_test.dart
(right):

https://codereview.chromium.org/1374943005/diff/20001/pkg/analysis_server/tes...
pkg/analysis_server/test/analysis/notification_implemented_test.dart:94: *
Subscribe for `IMPLEMENTED` and wait to the notification.
nit: "to" --> "for"

[scheglov, 2015-09-30 18:08:44]

Committed patchset #2 (id:20001) manually as
1d28f99524f5861762007db419094cbd5d78f993 (presubmit successful).