Issue 1374543002: Fixed checking for more complex inheritance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1374543002: Fixed checking for more complex inheritance (Closed)

Created:
5 years, 2 months ago by terry

Modified:
5 years, 2 months ago

Reviewers:
Alan Knight

CC:
reviews_dartlang.org, ricow1

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fixed checking for more complex inheritance TBR=alanknight@google.com Committed: https://github.com/dart-lang/sdk/commit/40fed7484892915cbbdc01a6f4caf0656cadd54d

Patch Set 1 #

Total comments: 1

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+133 lines, -43 lines)			Patch
	M	sdk/lib/html/dartium/html_dartium.dart	View		4 chunks	+67 lines, -22 lines	0 comments	Download
	M	tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate	View		4 chunks	+66 lines, -21 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

terry

Committed patchset #1 (id:1) manually as 40fed7484892915cbbdc01a6f4caf0656cadd54d (presubmit successful).

5 years, 2 months ago (2015-09-28 04:09:41 UTC) #1

Alan Knight

5 years, 2 months ago (2015-09-28 22:31:42 UTC) #2

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/1374543002/diff/1/tools/dom/templates/html/im...
File tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate (right):

https://codereview.chromium.org/1374543002/diff/1/tools/dom/templates/html/im...
tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate:245:
(metaDataMirror.name.startsWith('HTML') ||
metaDataMirror.name.startsWith('SVG'))) {
Aren't there classes in HTML that don't start with HTML? And why only those two.
What about web_gl or web_audio, etc?

Expand Messages | Collapse Messages