Issue 13744005: Making supressed DOM types abstract

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13744005: Making supressed DOM types abstract (Closed)

Created:
7 years, 8 months ago by blois

Modified:
7 years, 8 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Making supressed DOM types abstract This clears up a number of dart analyzer issues for the suppressed types. Also making SVGGradientElement not be suppressed since it is used. BUG= Committed: https://code.google.com/p/dart/source/detail?r=21111

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+183 lines, -117 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	20 chunks	+20 lines, -20 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	20 chunks	+20 lines, -20 lines	0 comments	Download
M	sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/indexed_db/dartium/indexed_db_dartium.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/svg/dart2js/svg_dart2js.dart	View	21 chunks	+62 lines, -34 lines	0 comments	Download
M	sdk/lib/svg/dartium/svg_dartium.dart	View	21 chunks	+62 lines, -34 lines	0 comments	Download
M	sdk/lib/web_sql/dart2js/web_sql_dart2js.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/web_sql/dartium/web_sql_dartium.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	3 chunks	+6 lines, -1 line	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	tools/dom/templates/dart2js_impl.darttemplate	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/dartium/dart_implementation.darttemplate	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

blois

7 years, 8 months ago (2013-04-08 20:45:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21111 (presubmit successful).

Expand Messages | Collapse Messages