Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 13744003: Add back localName and improve toString for Html nodes. (Closed)

Created:
7 years, 8 months ago by Emily Fortuna
Modified:
7 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add back localName and improve toString for Html nodes. BUG= Committed: https://code.google.com/p/dart/source/detail?r=21105

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -28 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 4 chunks +8 lines, -9 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 4 chunks +8 lines, -8 lines 0 comments Download
M tests/html/element_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/node_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/dom/src/AttributeMap.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Node.darttemplate View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Emily Fortuna
7 years, 8 months ago (2013-04-06 01:26:13 UTC) #1
Jennifer Messerly
lgtm
7 years, 8 months ago (2013-04-08 17:34:00 UTC) #2
Emily Fortuna
7 years, 8 months ago (2013-04-08 19:29:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21105 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698