Issue 1374373004: Clarify heap write protection interface and use WritableVMIsolateScope to resolve issue 23217.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1374373004: Clarify heap write protection interface and use WritableVMIsolateScope to resolve issue 23217. (Closed)

Created:
5 years, 2 months ago by koda

Modified:
5 years, 2 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Clarify heap write protection interface and use WritableVMIsolateScope to resolve issue 23217. BUG=23217 R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/f500a1bdd8e57750059005e2ee5260364a811427

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -22 lines)			Patch
M	runtime/vm/heap.h	View	2 chunks	+10 lines, -1 line	0 comments	Download
M	runtime/vm/heap.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+8 lines, -6 lines	0 comments	Download
M	runtime/vm/pages.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/pages.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/snapshot.cc	View	1 chunk	+0 lines, -13 lines	0 comments	Download

Total messages: 4 (1 generated)

koda

5 years, 2 months ago (2015-09-30 17:17:55 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f500a1bdd8e57750059005e2ee5260364a811427 (presubmit successful).