Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 13741025: Add more error detection to debugger test (Closed)

Created:
7 years, 8 months ago by hausner
Modified:
7 years, 8 months ago
Reviewers:
Tom Ball
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add more error detection to debugger test Detect when malformed messages leave over garbage, e.g. when there are is an extra closing brace. Committed: https://code.google.com/p/dart/source/detail?r=21119

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -4 lines) Patch
M tests/standalone/debugger/debug_lib.dart View 2 chunks +22 lines, -1 line 0 comments Download
M tools/ddbg.dart View 3 chunks +27 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
7 years, 8 months ago (2013-04-08 21:52:57 UTC) #1
Tom Ball
lgtm
7 years, 8 months ago (2013-04-08 22:02:57 UTC) #2
hausner
7 years, 8 months ago (2013-04-08 22:24:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21119 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698