Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1373873004: Make --noopt behave like an in-place precompilation. (Closed)

Created:
5 years, 2 months ago by rmacnak
Modified:
5 years, 2 months ago
Reviewers:
srdjan, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Bill Hesse
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make --noopt behave like an in-place precompilation. Breaks --noopt for IA32. R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/67c15fc982e8de09df3bbd786cffc9d9014ed4c5

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : sync + enable checked mode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -44 lines) Patch
M runtime/bin/main.cc View 1 7 chunks +27 lines, -7 lines 0 comments Download
M runtime/include/dart_api.h View 1 1 chunk +22 lines, -1 line 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 3 chunks +11 lines, -26 lines 0 comments Download
M runtime/vm/precompiler.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
M runtime/vm/precompiler.cc View 1 3 chunks +11 lines, -3 lines 0 comments Download
A + tests/standalone/noopt_test.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M tests/standalone/standalone.status View 1 2 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rmacnak
5 years, 2 months ago (2015-09-28 20:13:32 UTC) #2
srdjan
lgtm https://codereview.chromium.org/1373873004/diff/1/runtime/bin/main.cc File runtime/bin/main.cc (right): https://codereview.chromium.org/1373873004/diff/1/runtime/bin/main.cc#newcode335 runtime/bin/main.cc:335: vm_options->AddArgument("--precompilation_mode"); Do you need '_mode'? Maybe --precompilation is ...
5 years, 2 months ago (2015-09-29 23:27:48 UTC) #4
rmacnak
https://codereview.chromium.org/1373873004/diff/1/runtime/bin/main.cc File runtime/bin/main.cc (right): https://codereview.chromium.org/1373873004/diff/1/runtime/bin/main.cc#newcode335 runtime/bin/main.cc:335: vm_options->AddArgument("--precompilation_mode"); On 2015/09/29 23:27:47, srdjan wrote: > Do you ...
5 years, 2 months ago (2015-09-30 00:10:29 UTC) #5
rmacnak
+Bill, golem should be restarted to stop running --noopt on IA32 before I land this ...
5 years, 2 months ago (2015-09-30 00:12:04 UTC) #6
rmacnak
5 years, 2 months ago (2015-09-30 20:11:52 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:60001) manually as
67c15fc982e8de09df3bbd786cffc9d9014ed4c5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698