Issue 1373613002: Add public_config to :libdart in runtime/BUILD.gn

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1373613002: Add public_config to :libdart in runtime/BUILD.gn (Closed)

Created:
5 years, 2 months ago by Cutch

Modified:
5 years, 2 months ago

Reviewers:
jamesr

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add public_config to :libdart in runtime/BUILD.gn BUG= R=jamesr@chromium.org Committed: https://github.com/dart-lang/sdk/commit/2a9c5c0a91e514e6f0ae1062dafe35434de042ad

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	runtime/BUILD.gn	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jamesr

lgtm fyi the chromium GN style guide recommends a different ordering: https://chromium.googlesource.com/chromium/src/tools/gn/+/HEAD/docs/style_guide.md but I think ...

5 years, 2 months ago (2015-09-25 19:38:32 UTC) #3

Cutch

5 years, 2 months ago (2015-09-25 19:41:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
2a9c5c0a91e514e6f0ae1062dafe35434de042ad (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages