Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1373593002: Add navigation region for 'library' directives. (Closed)

Created:
5 years, 2 months ago by scheglov
Modified:
5 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add navigation region for 'library' directives. Dart Editor uses presence of a navigation region as a sign that there is something that can be renamed, and enables the Rename action. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/83f94a211451de502991159ed37d01f4cfc1dccb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -46 lines) Patch
M pkg/analysis_server/lib/src/domains/analysis/navigation_dart.dart View 3 chunks +51 lines, -46 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_navigation_test.dart View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 2 months ago (2015-09-25 19:14:28 UTC) #1
Brian Wilkerson
> Dart Editor uses presence of a navigation region as a sign that there is ...
5 years, 2 months ago (2015-09-25 19:32:41 UTC) #2
scheglov
5 years, 2 months ago (2015-09-25 19:35:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
83f94a211451de502991159ed37d01f4cfc1dccb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698