Avoid eagerly enqueueing converted forms of selectors or eagerly creating their converted symbols.

Avoid eagerly enqueueing converted forms of selectors or eagerly creating their symbols.

Fix setter closurization.

Shrinks precompiled snapshot by 11.4%.

R=hausner@google.com

Committed: https://github.com/dart-lang/sdk/commit/6a3255f4aeb8ac83c58285bb8c9b954d6b498c32

[rmacnak, 2015-09-29 18:35:50]

rmacnak@google.com changed reviewers:
+ hausner@google.com

[hausner, 2015-09-29 19:43:22]

lgtm w/comments

https://codereview.chromium.org/1373213003/diff/20001/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/1373213003/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:480: if (!IsSent(selector)) {
You enter this if for a null selector. Is that on purpose?

https://codereview.chromium.org/1373213003/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:583: selector2 = Symbols::Lookup(selector2);
Is this symbol guaranteed to exist?

https://codereview.chromium.org/1373213003/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:589: selector2 = Field::NameFromGetter(selector);
This has been computed above. Why do it again?

[rmacnak, 2015-09-29 20:40:06]

https://codereview.chromium.org/1373213003/diff/20001/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/1373213003/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:480: if (!IsSent(selector)) {
On 2015/09/29 19:43:21, hausner wrote:
> You enter this if for a null selector. Is that on purpose?

AddSelector should never be called with null, selectors from instance call
sites. Added assert. IsSent may see a null if we lookup a getter that doesn't
exist.

https://codereview.chromium.org/1373213003/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:583: selector2 = Symbols::Lookup(selector2);
On 2015/09/29 19:43:21, hausner wrote:
> Is this symbol guaranteed to exist?

In this case, yes. There cannot be a getter function without the corresponding
name having been made a symbol by the scanner. But it isn't guaranteed for the
other conversions below, and we generally don't rely on it existing. In fact we
hope it doesn't exist so we don't have to compile.

https://codereview.chromium.org/1373213003/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:589: selector2 = Field::NameFromGetter(selector);
On 2015/09/29 19:43:21, hausner wrote:
> This has been computed above. Why do it again?

Hoisted out.

[rmacnak, 2015-09-29 20:41:42]

Committed patchset #3 (id:40001) manually as
6a3255f4aeb8ac83c58285bb8c9b954d6b498c32 (presubmit successful).