Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 1373013002: VM: Fix bug in the new edge counter code on ARM and MIPS. (Closed)

Created:
5 years, 2 months ago by Florian Schneider
Modified:
5 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Fix bug in the new edge counter code on ARM and MIPS. The offset into the edge counter array may exceed the limit of what fits into an Address operand on ARM and MIPS. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/66bc931b6922b96c65b401a0cdee2c97a8233ae8

Patch Set 1 #

Total comments: 2

Patch Set 2 : removed dead code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M runtime/vm/flow_graph_compiler_arm.cc View 1 1 chunk +4 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Florian Schneider
5 years, 2 months ago (2015-09-28 17:04:24 UTC) #2
rmacnak
lgtm w/c https://codereview.chromium.org/1373013002/diff/1/runtime/vm/flow_graph_compiler_arm.cc File runtime/vm/flow_graph_compiler_arm.cc (right): https://codereview.chromium.org/1373013002/diff/1/runtime/vm/flow_graph_compiler_arm.cc#newcode1191 runtime/vm/flow_graph_compiler_arm.cc:1191: const Array& counter = Array::ZoneHandle(zone(), Array::New(1, Heap::kOld)); ...
5 years, 2 months ago (2015-09-28 17:15:27 UTC) #3
Florian Schneider
https://codereview.chromium.org/1373013002/diff/1/runtime/vm/flow_graph_compiler_arm.cc File runtime/vm/flow_graph_compiler_arm.cc (right): https://codereview.chromium.org/1373013002/diff/1/runtime/vm/flow_graph_compiler_arm.cc#newcode1191 runtime/vm/flow_graph_compiler_arm.cc:1191: const Array& counter = Array::ZoneHandle(zone(), Array::New(1, Heap::kOld)); On 2015/09/28 ...
5 years, 2 months ago (2015-09-28 17:17:25 UTC) #4
Florian Schneider
5 years, 2 months ago (2015-09-28 17:38:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
66bc931b6922b96c65b401a0cdee2c97a8233ae8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698