Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 137293004: Un-mark some pub tests as failing on the analyzer. (Closed)

Created:
6 years, 11 months ago by nweiz
Modified:
6 years, 11 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Un-mark some pub tests as failing on the analyzer. Removing SafeHttpServer caused these to start passing. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=31768

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M tests/lib/analyzer/analyze_library.status View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
6 years, 11 months ago (2014-01-14 00:03:32 UTC) #1
Bob Nystrom
lgtm
6 years, 11 months ago (2014-01-14 00:04:57 UTC) #2
nweiz
6 years, 11 months ago (2014-01-14 00:05:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r31768 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698