Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 13727004: Fixing HtmlDocument overloads (Closed)

Created:
7 years, 8 months ago by blois
Modified:
7 years, 8 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing HtmlDocument overloads This had a bunch of unnecessary/problematic redirections to the global document. BUG= Committed: https://code.google.com/p/dart/source/detail?r=21018

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -69 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 5 chunks +23 lines, -23 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 5 chunks +23 lines, -23 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate View 5 chunks +23 lines, -23 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 8 months ago (2013-04-05 22:00:12 UTC) #1
sra1
lgtm
7 years, 8 months ago (2013-04-06 00:53:16 UTC) #2
blois
7 years, 8 months ago (2013-04-06 00:57:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21018 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698