Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 1372623004: New analysis.implemented notification specification. (Closed)

Created:
5 years, 2 months ago by scheglov
Modified:
5 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Simplify to just list of classes/members that have implementations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+581 lines, -73 lines) Patch
M pkg/analysis_server/doc/api.html View 1 6 chunks +69 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 1 6 chunks +326 lines, -1 line 0 comments Download
M pkg/analysis_server/test/integration/integration_test_methods.dart View 1 3 chunks +35 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 1 4 chunks +46 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/generated/java/types/AnalysisService.java View 1 chunk +2 lines, -0 lines 0 comments Download
A + pkg/analysis_server/tool/spec/generated/java/types/ImplementedClass.java View 1 5 chunks +16 lines, -35 lines 0 comments Download
A + pkg/analysis_server/tool/spec/generated/java/types/ImplementedMember.java View 1 5 chunks +16 lines, -35 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 3 chunks +71 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scheglov
5 years, 2 months ago (2015-09-25 15:47:22 UTC) #1
scheglov
https://codereview.chromium.org/1372623004/diff/1/pkg/analysis_server/tool/spec/spec_input.html File pkg/analysis_server/tool/spec/spec_input.html (right): https://codereview.chromium.org/1372623004/diff/1/pkg/analysis_server/tool/spec/spec_input.html#newcode899 pkg/analysis_server/tool/spec/spec_input.html:899: <field name="implementedElements"> Unfortunately "implemented" is not a noun in ...
5 years, 2 months ago (2015-09-25 15:48:56 UTC) #2
scheglov
PTAL I used names ImplementedClass and ImplementedMember just to use corresponding names for the "analysis.implemented" ...
5 years, 2 months ago (2015-09-25 16:33:18 UTC) #3
Brian Wilkerson
LGTM
5 years, 2 months ago (2015-09-25 16:45:45 UTC) #4
scheglov
5 years, 2 months ago (2015-09-25 16:57:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
da29a447c4e8cf53417da0cc9ec5be16d2731088 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698