Issue 13726023: Restore r20998 with a bug fix: add field to guarded_fields_ when it contains relevant cid. Was miss…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13726023: Restore r20998 with a bug fix: add field to guarded_fields_ when it contains relevant cid. Was miss… (Closed)

Created:
7 years, 8 months ago by srdjan

Modified:
7 years, 8 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Restore r20998 with a bug fix: add field to guarded_fields_ when it contains relevant cid. Was missing most cases and did not check for unique adds. Committed: https://code.google.com/p/dart/source/detail?r=21008

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -69 lines)			Patch
M	runtime/vm/compiler.cc	View		3 chunks	+8 lines, -8 lines	0 comments	Download
M	runtime/vm/flow_graph.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/flow_graph.cc	View		1 chunk	+0 lines, -36 lines	0 comments	Download
M	runtime/vm/flow_graph_inliner.h	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View		5 chunks	+6 lines, -4 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.h	View		2 chunks	+7 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 2	4 chunks	+23 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

Committed patchset #3 manually as r21008 (presubmit successful).

7 years, 8 months ago (2013-04-05 23:27:04 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages