Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 13726008: Only emit "interactive" output if stdout supports colors. (Closed)

Created:
7 years, 8 months ago by ahe
Modified:
7 years, 8 months ago
Reviewers:
Ivan Posva, kustermann
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Only emit "interactive" output if stdout supports colors. Committed: https://code.google.com/p/dart/source/detail?r=20991

Patch Set 1 #

Patch Set 2 : Use TERM and tput -T #

Patch Set 3 : Added a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M dart/tools/build.py View 1 2 1 chunk +21 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ahe
7 years, 8 months ago (2013-04-05 16:07:05 UTC) #1
kustermann
lgtm
7 years, 8 months ago (2013-04-05 17:16:48 UTC) #2
ahe
Thank you, Martin. I added some comments as well.
7 years, 8 months ago (2013-04-05 18:02:11 UTC) #3
ahe
Committed patchset #3 manually as r20991 (presubmit successful).
7 years, 8 months ago (2013-04-05 18:02:39 UTC) #4
Ivan Posva
7 years, 8 months ago (2013-04-05 20:30:06 UTC) #5
Message was sent while issue was closed.
DBC

Now I get one huge line, followed by duplicated output. Paste the text below
into an 80-wide Terminal.

-Ivan


=== BUILD AGGREGATE TARGET generate_async_cc_file OF PROJECT dart-runtime WITH
C=== BUILD AGGREGATE TARGET generate_async_patch_cc_file OF PROJECT dart-runtime
=== BUILD AGGREGATE TARGET generate_corelib_cc_file OF PROJECT dart-runtime
WITH=== BUILD AGGREGATE TARGET generate_corelib_patch_cc_file OF PROJECT
dart-runtim=== BUILD AGGREGATE TARGET generate_collection_cc_file OF PROJECT
dart-runtime W=== BUILD AGGREGATE TARGET generate_collection_patch_cc_file OF
PROJECT dart-run=== BUILD AGGREGATE TARGET generate_collection_dev_cc_file OF
PROJECT dart-runti=== BUILD AGGREGATE TARGET generate_crypto_cc_file OF PROJECT
dart-runtime WITH === BUILD AGGREGATE TARGET generate_math_cc_file OF PROJECT
dart-runtime WITH CO=== BUILD AGGREGATE TARGET generate_math_patch_cc_file OF
PROJECT dart-runtime W=== BUILD AGGREGATE TARGET generate_isolate_cc_file OF
PROJECT dart-runtime WITH=== BUILD AGGREGATE TARGET
generate_isolate_patch_cc_file OF PROJECT dart-runtim=== BUILD AGGREGATE TARGET
generate_json_cc_file OF PROJECT dart-runtime WITH CO=== BUILD AGGREGATE TARGET
generate_json_patch_cc_file OF PROJECT dart-runtime W=== BUILD AGGREGATE TARGET
generate_mirrors_cc_file OF PROJECT dart-runtime WITH=== BUILD AGGREGATE TARGET
generate_mirrors_patch_cc_file OF PROJECT dart-runtim=== BUILD AGGREGATE TARGET
generate_typeddata_cc_file OF PROJECT dart-runtime WI=== BUILD AGGREGATE TARGET
generate_typeddata_patch_cc_file OF PROJECT dart-runt=== BUILD AGGREGATE TARGET
generate_uri_cc_file OF PROJECT dart-runtime WITH CON=== BUILD AGGREGATE TARGET
generate_utf_cc_file OF PROJECT dart-runtime WITH CON=== BUILD NATIVE TARGET
libdart_lib_withcore OF PROJECT dart-runtime WITH CONFIG=== BUILD NATIVE TARGET
libdart_lib OF PROJECT dart-runtime WITH CONFIGURATION D=== BUILD NATIVE TARGET
libdart_vm OF PROJECT dart-runtime WITH CONFIGURATION De=== BUILD NATIVE TARGET
libjscre OF PROJECT dart-runtime WITH CONFIGURATION Debu=== BUILD NATIVE TARGET
libdouble_conversion OF PROJECT dart-runtime WITH CONFIG=== BUILD NATIVE TARGET
libdart_dependency_helper OF PROJECT dart-runtime WITH C=== BUILD AGGREGATE
TARGET generate_version_cc_file OF PROJECT dart-runtime WITH=== BUILD NATIVE
TARGET libdart OF PROJECT dart-runtime WITH CONFIGURATION Debug=== BUILD
AGGREGATE TARGET pkg_packages OF PROJECT pkg WITH CONFIGURATION DebugI=== BUILD
AGGREGATE TARGET runtime_packages OF PROJECT dart-runtime WITH CONFIGU=== BUILD
AGGREGATE TARGET generate_snapshot_test_dat_file OF PROJECT dart-runti=== BUILD
AGGREGATE TARGET generate_builtin_cc_file OF PROJECT dart-runtime WITH=== BUILD
AGGREGATE TARGET generate_io_cc_file OF PROJECT dart-runtime WITH CONF=== BUILD
AGGREGATE TARGET generate_io_patch_cc_file OF PROJECT dart-runtime WIT=== BUILD
NATIVE TARGET libdart_builtin OF PROJECT dart-runtime WITH CONFIGURATI=== BUILD
NATIVE TARGET libdart_io OF PROJECT dart-runtime WITH CONFIGURATION De=== BUILD
NATIVE TARGET libdart_withcore OF PROJECT dart-runtime WITH CONFIGURAT=== BUILD
NATIVE TARGET gen_snapshot OF PROJECT dart-runtime WITH CONFIGURATION === BUILD
AGGREGATE TARGET generate_snapshot_bin OF PROJECT dart-runtime WITH CO=== BUILD
AGGREGATE TARGET generate_snapshot_bin OF PROJECT dart-runtime WITH
CONFIGURATION DebugIA32 ===

Powered by Google App Engine
This is Rietveld 408576698