Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 13725029: Fixing up a number of go.sh warnings (Closed)

Created:
7 years, 8 months ago by blois
Modified:
7 years, 8 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing up a number of go.sh warnings Tables have been falling out of date with IDL changes. BUG= Committed: https://code.google.com/p/dart/source/detail?r=21016

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -9 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 6 chunks +24 lines, -0 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 6 chunks +24 lines, -0 lines 0 comments Download
M tools/dom/scripts/generator.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/dom/scripts/htmleventgenerator.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 2 chunks +0 lines, -3 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 8 months ago (2013-04-06 00:20:04 UTC) #1
Emily Fortuna
lgtm. Thanks, this was starting to bug me, too. (but I hadn't done anything about ...
7 years, 8 months ago (2013-04-06 00:35:35 UTC) #2
blois
7 years, 8 months ago (2013-04-06 00:39:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21016 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698