Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1372433003: Remove CompilationUnit name requirement (Closed)

Created:
5 years, 3 months ago by vsm
Modified:
5 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove CompilationUnit name requirement Some of our language tests have '.lib' extensions for dart files that are imported. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/cac248765b3a0221a2659dc67e1ebd1282079b5b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
vsm
5 years, 3 months ago (2015-09-24 22:06:03 UTC) #2
Brian Wilkerson
LGTM
5 years, 3 months ago (2015-09-24 22:40:33 UTC) #3
vsm
5 years, 3 months ago (2015-09-24 22:51:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cac248765b3a0221a2659dc67e1ebd1282079b5b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698