Issue 1372353003: Don't early-exit teardowns after a signal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1372353003: Don't early-exit teardowns after a signal. (Closed)

Created:
5 years, 2 months ago by nweiz

Modified:
5 years, 2 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Don't early-exit teardowns after a signal. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/aae4ad1487e1ef7bb069ede5335cb806ddb1cf51

Patch Set 2 : Don't re-zone unnecessarily. #

Total comments: 2

Patch Set 3 : Code review changes #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -16 lines)			Patch
M	CHANGELOG.md	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	lib/src/backend/group.dart	View	1	1 chunk	+8 lines, -8 lines	0 comments	Download
M	lib/src/backend/invoker.dart	View	1 2	4 chunks	+39 lines, -7 lines	0 comments	Download
M	pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kevmoo

lgtm https://codereview.chromium.org/1372353003/diff/20001/lib/src/backend/invoker.dart File lib/src/backend/invoker.dart (right): https://codereview.chromium.org/1372353003/diff/20001/lib/src/backend/invoker.dart#newcode78 lib/src/backend/invoker.dart:78: : new Completer().future; Wha? Please explain...

5 years, 2 months ago (2015-10-01 02:21:24 UTC) #2

nweiz

Committed patchset #3 (id:40001) manually as aae4ad1487e1ef7bb069ede5335cb806ddb1cf51 (presubmit successful).

5 years, 2 months ago (2015-10-01 21:15:21 UTC) #4