Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1372333002: Add measurements and send-metrics to dart2js's info. (Closed)

Created:
5 years, 2 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dart2js_info.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add measurements and send-metrics to dart2js's info. This was originally reviewed at https://codereview.chromium.org/1220043005/, but now I have moved this to integrate it with the rest of dart2js's dumped info. Changes from that CL include: - Table has been split into a reusable library - All of the Global/Library/CompilationUnit result nodes are gone, the data is now attached directly in FunctionInfo - I had to add a url for source-spans into measurements. In the future this should go higher up in the info-hierarchy. R=johnniwinther@google.com Committed: https://github.com/dart-lang/dart2js_info/commit/ffd03ee45f7459efd3039ff565b4d0aa2e7cd9e7

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+944 lines, -5 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
A bin/inference/client.dart View 1 1 chunk +134 lines, -0 lines 0 comments Download
A bin/inference/index.html View 1 chunk +81 lines, -0 lines 0 comments Download
A bin/inference/print_summary.dart View 1 1 chunk +96 lines, -0 lines 0 comments Download
A bin/inference/server.dart View 1 1 chunk +46 lines, -0 lines 0 comments Download
M lib/info.dart View 6 chunks +38 lines, -3 lines 0 comments Download
A lib/src/measurements.dart View 1 1 chunk +251 lines, -0 lines 0 comments Download
A lib/src/string_edit_buffer.dart View 1 1 chunk +113 lines, -0 lines 0 comments Download
A lib/src/table.dart View 1 1 chunk +126 lines, -0 lines 1 comment Download
M lib/src/util.dart View 1 2 chunks +52 lines, -1 line 0 comments Download
M pubspec.yaml View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Siggi Cherem (dart-lang)
5 years, 2 months ago (2015-09-29 01:37:08 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/1372333002/diff/1/bin/inference/client.dart File bin/inference/client.dart (right): https://codereview.chromium.org/1372333002/diff/1/bin/inference/client.dart#newcode139 bin/inference/client.dart:139: class StringEditBuffer { This should have its own ...
5 years, 2 months ago (2015-10-02 10:09:49 UTC) #3
Siggi Cherem (dart-lang)
thanks! https://codereview.chromium.org/1372333002/diff/1/bin/inference/client.dart File bin/inference/client.dart (right): https://codereview.chromium.org/1372333002/diff/1/bin/inference/client.dart#newcode139 bin/inference/client.dart:139: class StringEditBuffer { On 2015/10/02 10:09:49, Johnni Winther ...
5 years, 2 months ago (2015-10-02 17:16:17 UTC) #4
Siggi Cherem (dart-lang)
5 years, 2 months ago (2015-10-02 17:16:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ffd03ee45f7459efd3039ff565b4d0aa2e7cd9e7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698