Support index.html in pub serve.

Support index.html in pub serve.

R=rnystrom@google.com
BUG=15020
Committed: https://code.google.com/p/dart/source/detail?r=32615

[Bob Nystrom, 2014-02-11 19:18:17]

Couple of suggestions then LGTM.

https://codereview.chromium.org/137233021/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/server.dart (right):

https://codereview.chromium.org/137233021/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/server.dart:117: return
barback.getAssetById(id.addExtension("/index.html")).then((asset) {
It conveniently does the right thing, but I think this is misusing the intent of
addExtension().

How about adding a separate "appendPath" or something like that to AssetId?

https://codereview.chromium.org/137233021/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/server.dart:121: // index.html is only
served when the URL has a trailing slash.
Move this comment up a line. Also, it took my a while to parse this. How about:

We only want to serve index.html if the URL explicitly ends in a slash. For
other URLs,
we redirect to one with the slash added to implicitly support that too. This
follows
Apache's behavior.

https://codereview.chromium.org/137233021/diff/1/sdk/lib/_internal/pub/test/s...
File sdk/lib/_internal/pub/test/serve/utils.dart (right):

https://codereview.chromium.org/137233021/diff/1/sdk/lib/_internal/pub/test/s...
sdk/lib/_internal/pub/test/serve/utils.dart:202: expect((response.statusCode /
100).floor(), equals(3));
Why not test for the specific status code?

If you do want to allow any 300-ish, you can do: response.statusCode ~/ 100

[nweiz, 2014-02-11 22:13:41]

https://codereview.chromium.org/137233021/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/server.dart (right):

https://codereview.chromium.org/137233021/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/server.dart:121: // index.html is only
served when the URL has a trailing slash.
On 2014/02/11 19:18:17, Bob Nystrom wrote:
> Move this comment up a line. Also, it took my a while to parse this. How
about:
> 
> We only want to serve index.html if the URL explicitly ends in a slash. For
> other URLs,
> we redirect to one with the slash added to implicitly support that too. This
> follows
> Apache's behavior.

Done.

https://codereview.chromium.org/137233021/diff/1/sdk/lib/_internal/pub/test/s...
File sdk/lib/_internal/pub/test/serve/utils.dart (right):

https://codereview.chromium.org/137233021/diff/1/sdk/lib/_internal/pub/test/s...
sdk/lib/_internal/pub/test/serve/utils.dart:202: expect((response.statusCode /
100).floor(), equals(3));
On 2014/02/11 19:18:17, Bob Nystrom wrote:
> Why not test for the specific status code?

Because any 30* code is a valid redirect. I didn't think that the value of
adding a parameter for a specific redirect code was worth the frustration of
having to specify it every time.

> If you do want to allow any 300-ish, you can do: response.statusCode ~/ 100

I didn't even realize that was an operator. Done.

[nweiz, 2014-02-12 19:10:17]

Committed patchset #2 manually as r32615 (presubmit successful).