pkg/unittest: deprecate expectAsyncN and expectAsyncUntilN

pkg/unittest: deprecate expectAsyncN and expectAsyncUntilN

add top-level expectAsync and expectAsyncUntil methods which take care of
counting arguments

R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32449

[Siggi Cherem (dart-lang), 2014-02-07 20:34:08]

very cool! LGTM

https://codereview.chromium.org/137223007/diff/1/pkg/unittest/lib/unittest.dart
File pkg/unittest/lib/unittest.dart (right):

https://codereview.chromium.org/137223007/diff/1/pkg/unittest/lib/unittest.da...
pkg/unittest/lib/unittest.dart:339: throw new StateError('Should never get
here');
let's change the message to help users know why :)

how about:
"Couldn't determine total number of arguments for callback. expectAsync only
supports functions that take 0, 1, or 2 arguments.

https://codereview.chromium.org/137223007/diff/1/pkg/unittest/lib/unittest.da...
pkg/unittest/lib/unittest.dart:394: throw new StateError('Should never get
here');
same here

https://codereview.chromium.org/137223007/diff/1/pkg/unittest/lib/unittest.da...
pkg/unittest/lib/unittest.dart:782: 'The callback argument has more than 2
required arguments.');
ah - I see, then you can keep the other state error, but maybe add a comment
saying that _minArgs will throw and that's why it is a state error.

[kevmoo, 2014-02-07 20:45:27]

https://codereview.chromium.org/137223007/diff/1/pkg/unittest/lib/unittest.dart
File pkg/unittest/lib/unittest.dart (right):

https://codereview.chromium.org/137223007/diff/1/pkg/unittest/lib/unittest.da...
pkg/unittest/lib/unittest.dart:339: throw new StateError('Should never get
here');
On 2014/02/07 20:34:08, Siggi Cherem (dart-lang) wrote:
> let's change the message to help users know why :)
> 
> how about:
> "Couldn't determine total number of arguments for callback. expectAsync only
> supports functions that take 0, 1, or 2 arguments.

Done.

https://codereview.chromium.org/137223007/diff/1/pkg/unittest/lib/unittest.da...
pkg/unittest/lib/unittest.dart:394: throw new StateError('Should never get
here');
On 2014/02/07 20:34:08, Siggi Cherem (dart-lang) wrote:
> same here

Done.

https://codereview.chromium.org/137223007/diff/1/pkg/unittest/lib/unittest.da...
pkg/unittest/lib/unittest.dart:782: 'The callback argument has more than 2
required arguments.');
On 2014/02/07 20:34:08, Siggi Cherem (dart-lang) wrote:
> ah - I see, then you can keep the other state error, but maybe add a comment
> saying that _minArgs will throw and that's why it is a state error.

Done.

[kevmoo, 2014-02-07 20:46:31]

Committed patchset #2 manually as r32449 (presubmit successful).