Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 1372213006: More mixin super tests. (Closed)

Created:
5 years, 2 months ago by sra1
Modified:
5 years, 2 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

More mixin super tests. Test for super method calls when method with super call is at multiple positions on subclass chain. It is not yet clear how to implement this efficiently in dart2js. R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/e3e8141069cf5a265b58de6c3c657ac4d892f374

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M tests/language/language_dart2js.status View 1 chunk +1 line, -0 lines 0 comments Download
A tests/language/mixin_super_2_test.dart View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
5 years, 2 months ago (2015-09-30 04:04:52 UTC) #3
regis
lgtm
5 years, 2 months ago (2015-09-30 15:10:57 UTC) #4
sra1
5 years, 2 months ago (2015-09-30 17:00:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
e3e8141069cf5a265b58de6c3c657ac4d892f374 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698