Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 13722025: Add dart2dart_bot rule. (Closed)

Created:
7 years, 8 months ago by floitsch
Modified:
7 years, 8 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add dart2dart_bot rule. Committed: https://code.google.com/p/dart/source/detail?r=21012

Patch Set 1 #

Patch Set 2 : Add packages as dependency of create_sdk #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M dart.gyp View 1 2 chunks +12 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
floitsch
7 years, 8 months ago (2013-04-06 00:01:37 UTC) #1
floitsch
TBR.
7 years, 8 months ago (2013-04-06 00:08:40 UTC) #2
floitsch
Committed patchset #2 manually as r21012 (presubmit successful).
7 years, 8 months ago (2013-04-06 00:09:30 UTC) #3
Ivan Posva
LGTMwC -Ivan https://codereview.chromium.org/13722025/diff/2001/dart.gyp File dart.gyp (right): https://codereview.chromium.org/13722025/diff/2001/dart.gyp#newcode69 dart.gyp:69: 'packages' Please add a TODO or make ...
7 years, 8 months ago (2013-04-06 00:09:45 UTC) #4
floitsch
On 2013/04/06 00:09:45, Ivan Posva wrote: > LGTMwC > > -Ivan > > https://codereview.chromium.org/13722025/diff/2001/dart.gyp > ...
7 years, 8 months ago (2013-04-06 00:15:11 UTC) #5
floitsch
7 years, 8 months ago (2013-04-06 00:15:43 UTC) #6
Message was sent while issue was closed.
On 2013/04/06 00:15:11, floitsch wrote:
> On 2013/04/06 00:09:45, Ivan Posva wrote:
> > LGTMwC
> > 
> > -Ivan
> > 
> > https://codereview.chromium.org/13722025/diff/2001/dart.gyp
> > File dart.gyp (right):
> > 
> > https://codereview.chromium.org/13722025/diff/2001/dart.gyp#newcode69
> > dart.gyp:69: 'packages'
> > Please add a TODO or make sure in some other way to remove this on Monday
when
> > the buildbot has been updated.
> Yes. I created a Bug with link to this CL.
http://dartbug.com/9704

Powered by Google App Engine
This is Rietveld 408576698