Issue 1372173005: Remove duplicate kind-to-c-string for LocalVarDescriptors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1372173005: Remove duplicate kind-to-c-string for LocalVarDescriptors. (Closed)

Created:
5 years, 2 months ago by rmacnak

Modified:
5 years, 2 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Remove duplicate kind-to-c-string for LocalVarDescriptors. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/9d699453280ba057bba242b3b769520dae5a4edc

Patch Set 1 #

Total comments: 1

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -29 lines)			Patch
	M	runtime/vm/object.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	runtime/vm/object.cc	View		5 chunks	+8 lines, -28 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rmacnak

https://codereview.chromium.org/1372173005/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/1372173005/diff/1/runtime/vm/object.cc#newcode11573 runtime/vm/object.cc:11573: return "CurrentCtx"; A test expects this name.

5 years, 2 months ago (2015-09-28 21:49:52 UTC) #2

rmacnak

5 years, 2 months ago (2015-09-29 17:01:23 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9d699453280ba057bba242b3b769520dae5a4edc (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages