Issue 1372173004: Ignore added files in hidden directories.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1372173004: Ignore added files in hidden directories. (Closed)

Created:
5 years, 2 months ago by Paul Berry

Modified:
5 years, 2 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Ignore added files in hidden directories. In commit 6ddc37a5cc402520da5d38695573cc335b8e8a35, the ContextManager was modified to disable analysis of files in hidden directories, provided those files existed prior to the creation of the context. This CL extends the fix to apply also to files that are added after context creation. Fixes #24212. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/f9aebddc67191b9c136ddff2e95db6869ce1b569

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -1 line)			Patch
	M	pkg/analysis_server/lib/src/context_manager.dart	View		2 chunks	+18 lines, -1 line	0 comments	Download
	M	pkg/analysis_server/test/context_manager_test.dart	View		3 chunks	+57 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paul Berry

5 years, 2 months ago (2015-09-28 21:10:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f9aebddc67191b9c136ddff2e95db6869ce1b569 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages