Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 137183004: Fix status files up after r31798 (Closed)

Created:
6 years, 11 months ago by ricow1
Modified:
6 years, 11 months ago
Reviewers:
floitsch, srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix status files up after r31798 The dart2js changed suppressions are not compatible with what was already there. The VM is timeing out on the ListMixin and ListBase test when optimizing after 5 iterations, filed dartbug.com/16101 to track this, skipping the test on all vm platforms for now. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=31825

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M tests/co19/co19-dart2dart.status View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/co19/co19-dart2js.status View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
6 years, 11 months ago (2014-01-15 08:24:09 UTC) #1
ricow1
Remove suppression from dart2dart status file since this was effectively not in action due to ...
6 years, 11 months ago (2014-01-15 08:34:43 UTC) #2
floitsch
LGTM.
6 years, 11 months ago (2014-01-15 09:26:25 UTC) #3
ricow1
6 years, 11 months ago (2014-01-15 11:36:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r31825 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698