Issue 137143018: Adapt tools/full-coverage.dart to changes in the isolate API and coverage output format.

Issue 137143018: Adapt tools/full-coverage.dart to changes in the isolate API and coverage output format. (Closed)

Created:
6 years, 10 months ago by rmacnak

Modified:
6 years, 10 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Adapt tools/full-coverage.dart to changes in the isolate API and coverage output format. BUG=http://dartbug.com/16352 R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=32256

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : address comments #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+105 lines, -104 lines)			Patch
	M	tools/full-coverage.dart	View	1 2	5 chunks	+105 lines, -104 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM with comments. -Ivan https://codereview.chromium.org/137143018/diff/20001/tools/full-coverage.dart File tools/full-coverage.dart (right): https://codereview.chromium.org/137143018/diff/20001/tools/full-coverage.dart#newcode297 tools/full-coverage.dart:297: List<List> split(List list, int nBuckets) ...

6 years, 10 months ago (2014-02-03 04:32:02 UTC) #2

rmacnak

https://codereview.chromium.org/137143018/diff/20001/tools/full-coverage.dart File tools/full-coverage.dart (right): https://codereview.chromium.org/137143018/diff/20001/tools/full-coverage.dart#newcode297 tools/full-coverage.dart:297: List<List> split(List list, int nBuckets) { On 2014/02/03 04:32:02, ...

6 years, 10 months ago (2014-02-03 18:31:55 UTC) #3

rmacnak

6 years, 10 months ago (2014-02-03 18:33:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r32256 (presubmit successful).

Expand Messages | Collapse Messages