Issue 137143014: Attempt to make stream-timeout test less flaky.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137143014: Attempt to make stream-timeout test less flaky. (Closed)

Created:
6 years, 10 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 10 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Attempt to make stream-timeout test less flaky. If the periodic timer gets starved long enough, the timeout might happen. If the 5ms periodic timer hasn't triggered in 250ms, discard the test (i.e., don't fail anyway). R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=32054

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	tests/lib/async/stream_timeout_test.dart	View		2 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

6 years, 10 months ago (2014-01-28 08:58:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r32054 (presubmit successful).

Expand Messages | Collapse Messages